Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove in-chat onboarding buttons for new chats #450

Merged
merged 8 commits into from
Aug 1, 2023

Conversation

toolmantim
Copy link
Contributor

@toolmantim toolmantim commented Jul 31, 2023

Show the in-chat onboarding buttons only for first time users who haven't created a new chat.

Before After
Screenshot 2023-07-31 at 4 01 19 pm Screenshot 2023-07-31 at 4 01 38 pm

Test plan

  • Clear history and view chat. Chat should have welcome buttons
  • Create a new chat. Chat should not have welcome buttons
  • Navigate chats with history, verified they don't have the welcome buttons

@toolmantim toolmantim requested a review from a team July 31, 2023 06:04
vscode/webviews/App.tsx Outdated Show resolved Hide resolved
@umpox
Copy link
Contributor

umpox commented Jul 31, 2023

@toolmantim Should this only show on the users first ever chat?

If so, I wonder if there's much value in keeping this functionality as it is. I'd imagine most users might never use this, as they could just skip past that first chat and never see it again. Understand that we might want to do more here in future for onboarding though.

Other question: If a user clears their history, should this then go to their oldest chat, or disappear completely?

I added a setup notification that would show for new users that hadn't configured Cody: https://github.com/sourcegraph/sourcegraph/pull/53321/files.

Maybe we want some similar logic like storing a global value as to if the user has ever interacted with Cody
context.globalState.get('user.hasInteractedPreviously')

That might allow us to do some more stuff here (thinking more about onboarding through the sidebar here too)

@toolmantim
Copy link
Contributor Author

toolmantim commented Aug 1, 2023

@umpox yeah good idea, it would be okay just to hide these as soon as someone uses the "New Chat" button! I'll look into that. (edit: in fact this is how web works with the privacy notice it displays)

I would like to keep the buttons in general for now to ensure we don't tank our onboarding metrics without properly testing and looking at existing numbers. But removing them in the future as we evolve things probably makes sense!

@toolmantim toolmantim changed the title Reduce noise on welcome message for new chats Remove in-chat onboarding buttons for new chats Aug 1, 2023
@toolmantim toolmantim marked this pull request as ready for review August 1, 2023 02:07
@toolmantim toolmantim requested review from a team and removed request for a team August 1, 2023 02:08
@toolmantim toolmantim merged commit 8d602df into main Aug 1, 2023
9 checks passed
@toolmantim toolmantim deleted the tl/hide-welcome-recipe-buttons-on-additional-chats branch August 1, 2023 02:59
@chenkc805
Copy link

I'm seeing a drop in retention, and I have a hunch that this change is the cause: https://sourcegraph.slack.com/archives/C05AGQYD528/p1691475546298529

@toolmantim @umpox does this affect brand new installs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants