Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove /post-sign-up needless redirect #4664

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sqs
Copy link
Member

@sqs sqs commented Jun 25, 2024

After sourcegraph/sourcegraph#63373, the /post-sign-up indirection/redirection is no longer necessary.

Test plan

Manually test in debug ext host sign out then sign in

After sourcegraph/sourcegraph#63373, the `/post-sign-up` indirection/redirection is no longer necessary.
@sqs sqs requested a review from chenkc805 June 25, 2024 00:09
@chenkc805
Copy link

@sqs
Copy link
Member Author

sqs commented Jun 28, 2024

@chenkc805 good to merge now? can you approve pls?

@chenkc805
Copy link

chenkc805 commented Jun 28, 2024

I don't know this code well enough. @vdavid knows this code but he's on pat leave.

Let me look at the git blame to see who's a good person to review

@chenkc805
Copy link

Looking at the git blame - both @philipp-spiess and @vdavid are unavailable to review this code. @dominiccooney - since you worked on the app-less signup flow last fall can I get your help reviewing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants