Remove OpenAI embedding model support #4747
Conversation
| @@ -32,7 +32,7 @@ export interface RemoteSearchProvider { | |||
| isIgnored: boolean | |||
| } | |||
|
|
|||
| export type EmbeddingsProvider = 'sourcegraph' | 'openai' | |||
There was a problem hiding this comment.
Decided not to delete this enum in case we add more providers later on.
| provider: 'openai', | ||
| endpoint: CODY_GATEWAY_PROD_ENDPOINT, | ||
| // empty prefix to keep backwards compatibility | ||
| indexPath: getIndexLibraryPath(''), |
There was a problem hiding this comment.
Should we have some code that deletes the old library here @janhartman ?
There was a problem hiding this comment.
Hm, good point. However, do we handle cleanups at all in Cody? I think we're just littering the users' machines all over the place 😓
There was a problem hiding this comment.
Not sure, but seeing that this is the "last clean-up", I think it would make sense to try?
There was a problem hiding this comment.
So this is the structure of the library... The files are from the OpenAI model (we don't use a prefix for backwards compatibility) while the dirs correspond to SG-provided models. So we have to delete only the files. Honestly, I think we can wait until we drop local embeddings entirely and then just nuke this whole dir.
There was a problem hiding this comment.
Ok, in the meantime we can tell the users to delete everything (we will regenerate if needed)
|
@rafax should I update the changelog with this change? It shouldn't really affect users but still... |
I don't think we need to do that (we're removing a feature that is not available). |
Test plan
N/A