fix: change file link color to match buttons #600
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE: https://sourcegraph.slack.com/archives/C04MSD3DP5L/p1691431852119019
The file link color was changed from
--vscode-textLink-foreground
to--vscode-button-secondaryForeground
for thelink-button
This makes the file links match the styling of the secondary buttons we currently use for the file links component, providing a more consistent user experience.
Test plan
Before:
Shades of Purple
![image](https://private-user-images.githubusercontent.com/68532117/258898808-4171f2a2-ba22-4f8d-ac0e-29090ad05f52.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE2MjEzMTQsIm5iZiI6MTcyMTYyMTAxNCwicGF0aCI6Ii82ODUzMjExNy8yNTg4OTg4MDgtNDE3MWYyYTItYmEyMi00ZjhkLWFjMGUtMjkwOTBhZDA1ZjUyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIyVDA0MDMzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM1NzQyNDI4ZTlhMTAwZjFhMTA4ZDYwY2ExM2NmNGIwNmFkNjAxOTE2MGU3OGNjZWUzNDBjNDcxM2EyYTM1NmUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ENUn2zqCG12j3mNP_bkkxyI0_xEXr8Aps8a5gUQNNVI)
Material theme palenight HC
![image](https://private-user-images.githubusercontent.com/68532117/258903570-3a74fbe0-5c6f-4198-8ff5-87be057b092f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE2MjEzMTQsIm5iZiI6MTcyMTYyMTAxNCwicGF0aCI6Ii82ODUzMjExNy8yNTg5MDM1NzAtM2E3NGZiZTAtNWM2Zi00MTk4LThmZjUtODdiZTA1N2IwOTJmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIyVDA0MDMzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBhOGZlZjZmYmI0ZDYzNzBiYjAxNzFmZGU0ZDljYmRkY2VkOTIzYzlkNWYyMjg0NDg4M2Q5M2E1ZGUyMjU5NjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.-40fW8e3U3sjTcRhcK1xA4PdshAYkW2XbvhVORK04Dw)
Light+ theme
![image](https://private-user-images.githubusercontent.com/68532117/258903748-0648ed8a-4aa5-4184-b74a-353f76f48aff.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE2MjEzMTQsIm5iZiI6MTcyMTYyMTAxNCwicGF0aCI6Ii82ODUzMjExNy8yNTg5MDM3NDgtMDY0OGVkOGEtNGFhNS00MTg0LWI3NGEtMzUzZjc2ZjQ4YWZmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIyVDA0MDMzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNjMDcyYzc2Nzc2OTA5Y2RkNmIyM2MyYjQ3ZDg0OTczZDg0NTM3OTNmMzRmMzI5MDlmMWZjMWUxOTE2YmUzMjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.nt6SalHNmB8-yLfZKt8v_8gXOqxvm9_cHvuMWY_gFkk)
Dark+
![image](https://private-user-images.githubusercontent.com/68532117/258904110-00d40497-f072-45b6-b233-24ab4a3a793f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE2MjEzMTQsIm5iZiI6MTcyMTYyMTAxNCwicGF0aCI6Ii82ODUzMjExNy8yNTg5MDQxMTAtMDBkNDA0OTctZjA3Mi00NWI2LWIyMzMtMjRhYjRhM2E3OTNmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIyVDA0MDMzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg0NTA2ZjVhMTdhZTU3YzNiZGQ1Y2U3YjE4MTAyOGViMzMwNzc1NTk4NzBjZGNjMTFlNjA0N2EwM2NkOThiOWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.q-_dZ2F7oHJO89Aa0ZonNAExAjbgMUjnzuzMF1ZAk-w)
After:
Shades of Purple
![image](https://private-user-images.githubusercontent.com/68532117/258898743-fd07f292-465a-466c-8737-706ef16fe639.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE2MjEzMTQsIm5iZiI6MTcyMTYyMTAxNCwicGF0aCI6Ii82ODUzMjExNy8yNTg4OTg3NDMtZmQwN2YyOTItNDY1YS00NjZjLTg3MzctNzA2ZWYxNmZlNjM5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIyVDA0MDMzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZjOGRkNWM3ZTFmZWEwZTViOTIyODVlZTBkZjFhNDgyZDQzZmRjNjExZjE0OTZlY2EzZDY1OTNlYjE4MjM4ODQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.4vlj4T9OpwpWq5JSRCd_SvaI00OrP4M2Wxxlircji7A)
Material theme palenight HC
![image](https://private-user-images.githubusercontent.com/68532117/258903542-42367aa8-f9ad-4903-bebd-0e8cc108ab23.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE2MjEzMTQsIm5iZiI6MTcyMTYyMTAxNCwicGF0aCI6Ii82ODUzMjExNy8yNTg5MDM1NDItNDIzNjdhYTgtZjlhZC00OTAzLWJlYmQtMGU4Y2MxMDhhYjIzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIyVDA0MDMzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE2OTRhOGUxMzc0NjJlZjlmNTIyYjdmZWQ4ZTk1NDM4M2JkYzAyMWMyZGY4Y2RlNGVmMWMyOTJjMjY5NDc5ZDkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.GC_cw8sky_P4WsHE1CdBLwITZJMGUuoh_iQGnIevj20)
Light+ theme
![image](https://private-user-images.githubusercontent.com/68532117/258903662-0e39fc24-1044-4f6c-9fe5-076151866aec.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE2MjEzMTQsIm5iZiI6MTcyMTYyMTAxNCwicGF0aCI6Ii82ODUzMjExNy8yNTg5MDM2NjItMGUzOWZjMjQtMTA0NC00ZjZjLTlmZTUtMDc2MTUxODY2YWVjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIyVDA0MDMzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJjMjY3MzM5OGM2NTFmN2MxZWIxM2ZmZDA0YTcwNjRhMWQ2YTRmMTA0YjA4MWUxNzU5YzY3ZjA3Zjc5ZmFiZjAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.9FGUhVRJX_u2YeZb3rH_rBZuMhpPGiOGXQl10kTkjBA)
Dark +
![image](https://private-user-images.githubusercontent.com/68532117/258904157-aedbd84c-12fb-4759-b445-c81b807f7482.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE2MjEzMTQsIm5iZiI6MTcyMTYyMTAxNCwicGF0aCI6Ii82ODUzMjExNy8yNTg5MDQxNTctYWVkYmQ4NGMtMTJmYi00NzU5LWI0NDUtYzgxYjgwN2Y3NDgyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIyVDA0MDMzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg1OWViZWJkNTAxMzBhYTc2NDkwM2ExYWQ2MDk5YTRiOWRlMGIzZGQzYzI4ZTZjZGE5OTQxZTJkMTYzOGExMzImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.rv7l5bR-vPCYZ_NKdVdxMoeRO10-CsvHk7g6p4nJQFk)