Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code: Don't add "Reload Window" actions to all views #603

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

toolmantim
Copy link
Contributor

#53908 introduced a stray system-wide "Reload Window" action. This reverts that change and fixes #601.

Before After
Screenshot 2023-08-08 at 11 52 25 am Screenshot 2023-08-08 at 11 53 09 am

Test plan

  • Opened views, checked reload option doesn't exist
  • Used the Cody Settings palette to enable/disable features, click "Reload Window" in notification and verified still works

@toolmantim toolmantim requested a review from a team August 8, 2023 01:59
@toolmantim toolmantim changed the title VSCody: Don't add "Reload Window" actions to all views VSCode: Don't add "Reload Window" actions to all views Aug 8, 2023
@toolmantim toolmantim requested a review from a team August 8, 2023 02:00
Copy link
Contributor

@abeatrix abeatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

if we want to keep Roload Window, just not adding it to all views, we can add a when clause to get it to show only when view == cody.chat?

{
          "command": "workbench.action.reloadWindow",
          "title": "Reload",
          "group": "8_cody@0",
          "when": "view == cody.chat"
        }

@toolmantim
Copy link
Contributor Author

@abeatrix I assumed it snuck in to help with development — but was there a need to add it for users?

@abeatrix
Copy link
Contributor

abeatrix commented Aug 8, 2023

@toolmantim not really, since we've added the reload button to the status bar item:
image

It was added to make it easier for users to reload when we were on a debugging call (e.g. ask them to click reload window via the menu instead of restarting VS Code)

@toolmantim
Copy link
Contributor Author

@abeatrix ah, cool. Yeah I'd say that's not a strong enough case to keep it, if we can advise them to ⌘-R to do the same thing. But if it's becoming an issue again on calls, let's relook at it.

@toolmantim toolmantim merged commit 19c821d into main Aug 8, 2023
9 checks passed
@toolmantim toolmantim deleted the tl/vscody-hide-reload-window-action branch August 8, 2023 02:18
@toolmantim toolmantim changed the title VSCode: Don't add "Reload Window" actions to all views VS Code: Don't add "Reload Window" actions to all views Aug 9, 2023
toolmantim added a commit that referenced this pull request Aug 9, 2023
Adds the changelog entries that were forgotten in #605 and #603

## Test plan

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cody is adding a "Reload Window" action to many views
2 participants