-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: log token count for code generated and button click events across the extension #675
Conversation
Thanks! Mostly looks good to me. Let me give this a spin in the IDE to QA later today QQ, for the first 3 events:
Don't we already have events for these as "executed" events? CC: @kelsey-brown |
@chenkc805 They are currently logged as:
But this does not capture the |
@abeatrix Is the goal to centralize the "chat" events for VSCode under one event name, add the This looks good overall, I think the only thing I'd love to see if possible is for the source (command menu, sidebar, inline) and the action (copy, paste, insert) to be logged in the same place/uniformly for relevant events. E.g. for copy events they always have |
@kelsey-brown basically, yes. Cause the recipe executed from chat does not always log under
I was following what the naming of the existing event added by the data team but I can look into updating those. |
This naming is totally fine! I actually think the easiest way to do this would just be to change these:
So all the copy events contain |
@kelsey-brown Fair! Just updated:
|
Having trouble getting my local environment setup so I'll review this in pre-release. Based on the documentation here though, looks good to me. |
RE: https://docs.google.com/document/d/1UcjUdon1XO5GoLDIJJCGBq1zyhR6VfL2FE_apSPeLQo/edit#heading=h.m8ojuhhojtjm
Close #672
Add loggings for following events
CodyVSCodeExtension:completion:accepted
was added by @philipp-spiess in #674CodyVSCodeExtension:completion:suggested
is not added. Will work on this in a separated PRTest plan
Added test for token count methods.
To test the newly added token events
Start Cody from this branch in debug mode, and check the Output channel for logged events after performing an action: