Don't require Esc to dismiss Cody menu #700
Conversation
| @@ -83,7 +83,6 @@ export class CustomCommandsBuilderMenu { | |||
| title: 'Select the context to include with the prompt for the new command', | |||
| placeHolder: 'Tip: Providing limited but precise context helps Cody provide more relevant answers', | |||
| canPickMany: true, | |||
| ignoreFocusOut: false, | |||
There was a problem hiding this comment.
let's keep this one? For users who are following the tutorial steps in the notebook might want to switch between screens during the new command building step (happened to me plenty of time 😅 ).
There was a problem hiding this comment.
Oh, I removed it because ignoreFocusOut: false is the default value and thought it was a noop. Want me to re-add, or change it to ignoreFocusOut: true?
There was a problem hiding this comment.
by "let's keep this one?" i meant to say set it to true ignoreFocusOut: true,*
There was a problem hiding this comment.
github is slow for me today 😅 Yea let's change it to ignoreFocusOut: true?
There was a problem hiding this comment.
I'm not sure why it was false to begin with, but I think it makes sense to be true like you said. I've just updated it.
| @@ -83,7 +83,6 @@ export class CustomCommandsBuilderMenu { | |||
| title: 'Select the context to include with the prompt for the new command', | |||
| placeHolder: 'Tip: Providing limited but precise context helps Cody provide more relevant answers', | |||
| canPickMany: true, | |||
| ignoreFocusOut: false, | |||
There was a problem hiding this comment.
by "let's keep this one?" i meant to say set it to true ignoreFocusOut: true,*
| @@ -83,7 +83,6 @@ export class CustomCommandsBuilderMenu { | |||
| title: 'Select the context to include with the prompt for the new command', | |||
| placeHolder: 'Tip: Providing limited but precise context helps Cody provide more relevant answers', | |||
| canPickMany: true, | |||
| ignoreFocusOut: false, | |||
There was a problem hiding this comment.
github is slow for me today 😅 Yea let's change it to ignoreFocusOut: true?
| @@ -83,7 +83,6 @@ export class CustomCommandsBuilderMenu { | |||
| title: 'Select the context to include with the prompt for the new command', | |||
| placeHolder: 'Tip: Providing limited but precise context helps Cody provide more relevant answers', | |||
| canPickMany: true, | |||
| ignoreFocusOut: false, | |||
This removes the
ignoreFocusOut: truesettings on our command quickpick, removing the need for you use to pressescin the input to dismiss it. This makes it feel just as quick and light as the standardcmd-shift-pcommand palette.The one downside to removing it is if you need to change your code selection mid-quickpick-item-selection, but given the standard command palette has commands that depend on code selection too (e.g. "Transform to Kebab Case") I think we should follow their suit and not introduce the extra bit of friction that requiring
escadds.Test plan