Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commands: match commands on description #702

Merged
merged 3 commits into from
Aug 16, 2023
Merged

commands: match commands on description #702

merged 3 commits into from
Aug 16, 2023
+4 −2

Conversation

abeatrix
Copy link
Contributor

@abeatrix abeatrix commented Aug 16, 2023 •
edited
Loading

This change makes the VS Code command menu match on the command description, not just the title.

This enables searching /commands in the menu.

Test plan

Demo:

image image

@abeatrix abeatrix requested review from toolmantim and a team August 16, 2023 05:55
@toolmantim
Copy link
Contributor

So keen to get this updated. But could we have it match the designs in Figma?
https://www.figma.com/file/9112BsKsJc1BpO2j8XYwLL/%F0%9F%A4%96-Cody-VS-Code-%5BMain%5D?type=design&node-id=4560-11184&mode=design&t=WvJcepme3DSbUmO6-4

toolmantim
toolmantim approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@toolmantim toolmantim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I misunderstood this as also changing the quickpick text! 😅 Yes, this is a Good Change™

@abeatrix abeatrix merged commit 5895b8e into main Aug 16, 2023
9 checks passed
@abeatrix abeatrix deleted the bee/matchOnDescription branch August 16, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toolmantim toolmantim toolmantim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abeatrix @toolmantim