update dotcomUrl #730

akalia25 · 2023-08-17T21:58:02Z

This PR does two things:

update the if statement that sends events to dotcom to do a match on hostname (avoids issue with serverEndpoint and dotcomUrl not matching because "sourcegraph.com" != "sourcegraph.com/"
sends to sendEventLogRequestToAPI to have proper user_ids.

Test plan

tested locally

update the url to match the serverEndpoint; this avoids double logging

lib/shared/src/sourcegraph-api/graphql/client.ts

dotcom events are associated with user_id and configuration information.

nathan-downs

LGTM!

akalia25 · 2023-08-17T22:36:12Z

As @nathan-downs mentioned sending to sendEventLogRequestToAPI will now have proper user_ids. Verified below with local testing:

update dotcomUrl

8c7f5b7

update the url to match the serverEndpoint; this avoids double logging

akalia25 marked this pull request as ready for review August 17, 2023 22:00

akalia25 requested a review from nathan-downs August 17, 2023 22:00

akalia25 added 2 commits August 17, 2023 18:11

use hostname to match if we should send to dotcom api only

5340251

simplify to use existing dotcomUrl

9d6d0cb

nathan-downs reviewed Aug 17, 2023

View reviewed changes

lib/shared/src/sourcegraph-api/graphql/client.ts Outdated Show resolved Hide resolved

autheniticated request instead of anonymous

8321a74

dotcom events are associated with user_id and configuration information.

nathan-downs approved these changes Aug 17, 2023

View reviewed changes

prettier

efe3670

akalia25 requested a review from a team August 17, 2023 22:37

dominiccooney approved these changes Aug 18, 2023

View reviewed changes

dominiccooney merged commit 9316241 into main Aug 18, 2023
10 checks passed

dominiccooney deleted the akalia25-patch-1 branch August 18, 2023 02:16