Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CODY_FOCUS_SIDEBAR_ON_STARTUP #796

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

umpox
Copy link
Contributor

@umpox umpox commented Aug 23, 2023

Description

Removes the auto focusing of Cody when we start local development.

The reasoning is that this is not a typical flow for any of our users. We are possibly building false assumptions and even missing bugs by doing this.

Also:

  • Some logic only runs when the sidebar is open, always having the sidebar open from the start means we can miss some bugs when this code doesn't run (Autocomplete: Fix codebase context inference for embeddings #525)
  • The sidebar is no longer the obvious way to interact with Cody. We're possibly overemphasising parts of this because it's always visible to us.

Test plan

Local dev change, tested by running local dev

@umpox umpox requested a review from a team August 23, 2023 09:59
Copy link
Contributor

@taras-yemets taras-yemets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to me! Thank you, Tom!

@umpox umpox merged commit 0ce01f0 into main Aug 23, 2023
9 checks passed
@umpox umpox deleted the tr/remove-focus-sidebar-on-startup branch August 23, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants