Autocomplete: Surface rate limit and other errors #851
Conversation
|
@toolmantim Please take a look at the attached video if this workflow makes sense for you. I've decided to add it to the same quick pick that the status bar item always opens (which is different from your UI sketches). The rest should be fairly similar. |
| } | ||
|
|
||
| const DEFAULT_TEXT = '$(cody-logo-heavy)' | ||
| const DEFAULT_TOOLTIP = 'Cody Settings' | ||
|
|
||
| const QUICK_PICK_ITEM_CHECKED_PREFIX = '$(check) ' | ||
| const QUICK_PICK_ITEM_EMPTY_INDENT_PREFIX = '\u00A0\u00A0\u00A0\u00A0 ' | ||
| const QUICK_PICK_ITEM_EMPTY_INDENT_PREFIX = '\u00A0\u00A0\u00A0\u00A0\u00A0 ' |
There was a problem hiding this comment.
@toolmantim For me the existing indentation looked a bit too narrow:
Before
After
But maybe that's different for other themes?
There was a problem hiding this comment.
Should have added these lines right away so it's clearer what I mean :D
| @@ -1,13 +1,13 @@ | |||
| import { LRUCache } from 'lru-cache' | |||
| import * as vscode from 'vscode' | |||
|
|
|||
| import { isAbortError, isRateLimitError } from '@sourcegraph/cody-shared/src/sourcegraph-api/errors' | |||
philipp-spiess
force-pushed
the
ps/autocomplete-error-reporting
branch
from
d5c0afc
to
1cd432a
Compare
There was a problem hiding this comment.
Looks great!
I put up a quick docs addition in sourcegraph/sourcegraph#56304 so we can link to there in stead of the blog.
Co-authored-by: Tim Lucas <t@toolmantim.com>
|
@toolmantim @valerybugakov Quick update: I decided to only surface rate limiting errors for now until we resolve https://sourcegraph.slack.com/archives/C05AGQYD528/p1693473094573439?thread_ts=1693471486.690459&cid=C05AGQYD528 This would be too much spam otherwise and definitely not a loveable experience |
Closes #634
This PR adds a UI indicator for autocomplete errors. We special case rate limiting errors to provider more information.
errorAPI similar to thedebugone but that will always log errors to the output channel.ToDo
errorAPI similar to thedebugone but that will always log errors to the output channel.Test plan
Screen.Recording.2023-08-29.at.14.04.23.mov