Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete: trigger multiline completions on empty block only #913

Merged
merged 9 commits into from
Sep 5, 2023
Merged

Autocomplete: trigger multiline completions on empty block only #913

merged 9 commits into from
Sep 5, 2023

Conversation

valerybugakov
Copy link
Member

@valerybugakov valerybugakov commented Sep 4, 2023 •
edited
Loading

Context

  • Trigger single-line completions instead of multi-line if a cursor is placed at the beginning of a non-empty block.
  • Discussed here.

Test plan

CI

@valerybugakov valerybugakov self-assigned this Sep 4, 2023
philipp-spiess
philipp-spiess approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this change but

  • Let's add it to the change log
  • Let's add a test for it

Base automatically changed from vb/text-processing-utils to main September 5, 2023 01:42
@valerybugakov valerybugakov marked this pull request as ready for review September 5, 2023 02:21
@valerybugakov valerybugakov merged commit b70e5f7 into main Sep 5, 2023
17 checks passed
@valerybugakov valerybugakov deleted the vb/trigger-multline-on-empty-block-only branch September 5, 2023 02:46
@valerybugakov valerybugakov mentioned this pull request Sep 14, 2023
Merged
valerybugakov added a commit that referenced this pull request Sep 15, 2023
@valerybugakov
Autocomplete: trigger multiline completions on empty block only (#1052)
8efaaff 
- A follow-up for #913
- Apply the same logic to `enableExtendedTriggers` (non-empty-line
multi-line triggers): do not trigger multi-line completions for opening
brackets if the content already exists in the block.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipp-spiess philipp-spiess philipp-spiess approved these changes

Assignees

@valerybugakov valerybugakov

Labels
autocomplete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@valerybugakov @philipp-spiess