Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete: Fix feature flag init #965

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Conversation

philipp-spiess
Copy link
Contributor

Feature flags in the provider init code won't evaluate right now because I forgot to pass through the feature flag provider 馃う

We need a patch release out with this, pronto.

Test plan

Screenshot 2023-09-07 at 11 55 57

@philipp-spiess philipp-spiess requested a review from a team September 7, 2023 09:59
@philipp-spiess philipp-spiess self-assigned this Sep 7, 2023
@philipp-spiess philipp-spiess merged commit b79e80b into main Sep 7, 2023
9 checks passed
@philipp-spiess philipp-spiess deleted the ps/ac-fix-ff-init branch September 7, 2023 10:11
philipp-spiess added a commit that referenced this pull request Sep 7, 2023
Feature flags in the provider init code won't evaluate right now because
I forgot to pass through the feature flag provider 馃う

We need a patch release out with this, pronto.

## Test plan

<img width="747" alt="Screenshot 2023-09-07 at 11 55 57"
src="https://github.com/sourcegraph/cody/assets/458591/d2ebc1af-cdc9-4bbf-a0cd-4cdbc619cc5d">


<!-- Required. See
https://docs.sourcegraph.com/dev/background-information/testing_principles.
-->
philipp-spiess added a commit that referenced this pull request Sep 7, 2023
Preparing a patch release of 0.10.1. It contains two cherry-picked
commits from #965 and #966
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants