Autocomplete: Don't init when not logged in and add UI to show that to users #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiccooney
approved these changes
Sep 8, 2023
| } | ||
| // Reload autocomplete if either the configuration changes or the auth status is updated | ||
| vscode.workspace.onDidChangeConfiguration(event => { | ||
| if (event.affectsConfiguration('cody.autocomplete')) { |
There was a problem hiding this comment.
Alternatively, I think you could have dependend on the cody.activated state. I believe the AuthProvider flips that (or tries to) when auth changes.
There was a problem hiding this comment.
Oh I see this is using this feature but couldn't find out how we can listen to these changes in code. I think this API is only for config changes but maybe I’m missing something? I'll merge this as-is but happy to change this if you find a nice way!
There was a problem hiding this comment.
@philipp-spiess Yes, unfortunately you can't listen to these in code. But for making UX changes you can use when/enablement to do that declaratively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #928
Avoid setting up autocomplete when the user is not signed in and log the states properly to the UI.
Test plan
Screen.Recording.2023-09-07.at.13.35.06.mov