Autocomplete: Add bare bones statistics logging and UI #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiccooney
approved these changes
Sep 8, 2023
vscode/src/completions/logger.ts
Outdated
| @@ -110,6 +117,9 @@ export function loaded(id: string): void { | |||
| // Suggested completions will not be logged immediately. Instead, we log them when we either hide | |||
| // them again (they are NOT accepted) or when they ARE accepted. This way, we can calculate the | |||
| // duration they were actually visible for. | |||
| // | |||
| // For statistics logging we start a timeout matching the READ_TIMEOUT so we can increment the | |||
There was a problem hiding this comment.
Realize this isn't a new name, but it is nice to put the units on quantities ie READ_TIMEOUT_MSEC because it can make it easier to catch some clowntown with dimensions in review.
| function statisticSummary(): string { | ||
| const { accepted, suggested } = statistics.getStatistics() | ||
| return `📈 Suggested: ${suggested} | Accepted: ${accepted} | Acceptance rate: ${ | ||
| suggested === 0 || accepted === 0 ? 'N/A' : `${((accepted / suggested) * 100).toFixed(2)}%` |
There was a problem hiding this comment.
You could still calculate an acceptance rate with accepted === 0, right?
There was a problem hiding this comment.
Haha yes of course 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often find myself wanting to know when exactly we count something as suggested vs. when we count it as accepted. Looking at the output tab is not super helpful here either so I added a small UI to the trace view.
This also adds the "infra" to support the trace view to show other views that re-render which I want to use for the section observer shortly.
I’m specifically hoping that this will help with #923.
Test plan
Screen.Recording.2023-09-07.at.15.31.10.mov