-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX improvements to the custom command workflow #992
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
It would be better if we added a type like:
type CustomPromptType = 'user' | 'workspace'
and referred to that everywhere instead of repeating 'user' | 'workspace'
. That will considerably reduce toil if we add a third kind of custom command, maybe ones synced with your whole Enterprise or something, because we can expand the type in one place and follow the type errors.
@dominiccooney thanks! Updated to use |
UX improvements to the custom command workflow:
Requires
Test plan