Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX improvements to the custom command workflow #992

Merged
merged 35 commits into from
Sep 14, 2023

Conversation

toolmantim
Copy link
Contributor

@toolmantim toolmantim commented Sep 11, 2023

UX improvements to the custom command workflow:

  • Improved labels
  • Gives you the choice of where to store the custom command
  • Saved notification now has a button for opening the settings and inspecting the results
  • Fixes bug where you can incorrectly choose the same slash name as an existing command
  • Move examples from the generated config to the new Custom Commands docs
Screenshot 2023-09-11 at 8 56 39 am

custom-command-setup-6

Screenshot 2023-09-11 at 9 25 39 am

Requires

Test plan

  • Opened the custom commands quickpick
  • Manually ran through the new command builder flow
  • Clicked new buttons, inspected JSON

@toolmantim toolmantim requested a review from a team September 13, 2023 11:37
Copy link
Contributor

@dominiccooney dominiccooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

It would be better if we added a type like:

type CustomPromptType = 'user' | 'workspace'

and referred to that everywhere instead of repeating 'user' | 'workspace'. That will considerably reduce toil if we add a third kind of custom command, maybe ones synced with your whole Enterprise or something, because we can expand the type in one place and follow the type errors.

vscode/src/chat/protocol.ts Outdated Show resolved Hide resolved
@toolmantim
Copy link
Contributor Author

@dominiccooney thanks! Updated to use CustomCommandType in 1c96984.

@toolmantim toolmantim merged commit 765eea9 into main Sep 14, 2023
11 checks passed
@toolmantim toolmantim deleted the tl/custom-command-quickpick-tweaks branch September 14, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants