Fix for prometheus scraping of cAdvisor metrics (#957)

* exposing cadvisor metrics on port 48080 for prometheus scraping * update comment --------- Co-authored-by: Jacob Pleiness <jdpleiness@users.noreply.github.com>
sourcegraph · Nov 20, 2023 · fb6dc7e · fb6dc7e
1 parent 81ca27f
commit fb6dc7e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/docker-compose/docker-compose.yaml b/docker-compose/docker-compose.yaml
@@ -486,7 +486,7 @@ services:
   # Description: Publishes Prometheus metrics about Docker containers.
   #
   # Disk: none
-  # Ports exposed to other Sourcegraph services: 8080/TCP
+  # Ports exposed to other Sourcegraph services: 48080/TCP
   # Ports exposed to the public internet: none
   #
   cadvisor:
@@ -513,8 +513,8 @@ services:
     networks:
       - sourcegraph
     restart: always
-    command:
-      - --port=8080
+    expose:
+      - 48080
 
   # Description: Publishes Prometheus metrics about the machine's hardware / operating system.
   #

diff --git a/prometheus/prometheus_targets.yml b/prometheus/prometheus_targets.yml
@@ -3,7 +3,7 @@
     nodename: "sourcegraph-docker-compose-host"
     job: node
   targets:
-    - cadvisor:8080
+    - cadvisor:48080
     - sourcegraph-frontend-internal:6060
 - labels:
     nodename: "sourcegraph-docker-compose-host"