Support container args override

[michaellzc]

close sourcegraph/sourcegraph#29063

Test plan

Install a release from the previous commit,

git checkout HEAD~
helm install -n sourcegraph -f charts/sourcegraph/override.yaml sourcegraph charts/sourcegraph/.

Checkout back to the current branch and run helm diff, you should see no breaking change

git checkout 02-22-Support_container_args_override
helm diff -n sourcegraph -f charts/sourcegraph/override.yaml sourcegraph charts/sourcegraph/.

[michaellzc]

Current dependencies on/for this PR:

• main
  • PR Support container args override #44 (this PR)

This comment was auto-generated by Graphite.

[michaellzc]

It was missing the env:

[caugustus-sourcegraph]

Nice! A few containers aren't included in this change - was this intentional? None of them seem likely to be customized and most are quite tricky because they're shared across deployments. Just wanted to confirm it was a deliberate choice.

• cadvisor
• jaeger agent (_tracing.tpl)
• alpine init containers
• redis exporter containers
• postgres exporter containers

[michaellzc]

Nice! A few containers aren't included in this change - was this intentional? None of them seem likely to be customized and most are quite tricky because they're shared across deployments. Just wanted to confirm it was a deliberate choice.

• cadvisor
• jaeger agent (_tracing.tpl)
• alpine init containers
• redis exporter containers
• postgres exporter containers

I definitely missed advisor

For redis exporter, postgres exporter and correct-data-dir-permissions (alpine init containers), we can nest them under the parent services, such as

redisCache:
  redisExporter:
    args: ["stuff"]

for jaeger, probably not worth making it customizable, or we just add a global flag tracingAgent.args