Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default global tolerations value #45

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Fix default global tolerations value #45

merged 1 commit into from
Feb 24, 2022

Conversation

michaellzc
Copy link
Member

@michaellzc michaellzc commented Feb 24, 2022 •
edited

Test plan

before the change running helm template

coalesce.go:220: warning: cannot overwrite table with non table for sourcegraph.sourcegraph.tolerations (map[])

After the change, it's no longer there.

@michaellzc
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@michaellzc michaellzc mentioned this pull request Feb 24, 2022
Merged
2 tasks
@michaellzc michaellzc marked this pull request as ready for review February 24, 2022 17:38
@michaellzc michaellzc merged commit 5829583 into main Feb 24, 2022
@michaellzc michaellzc deleted the Fix_default_global_tolerations_value branch February 24, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugustus-sourcegraph caugustus-sourcegraph caugustus-sourcegraph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaellzc @caugustus-sourcegraph