Fix default-container annotations
#47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
caugustus-sourcegraph
approved these changes
Feb 25, 2022
There was a problem hiding this comment.
Fantastic - thank you for making this change! There's an open PR to resolve it for kustomize deployments but Filip is out for a few weeks so we may just need to take it over.
| @@ -21,6 +21,7 @@ spec: | |||
| serviceName: indexed-search | |||
| template: | |||
| metadata: | |||
| annotations: | |||
|
Side note, this problem is less irritating with kubectl v1.24 - kubernetes/kubernetes#105964 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quality of life improvement
kubectl.kubernetes.io/default-containerannotation should be configured in the pod template.spec.template.metadatainstead of at deploy/sts level.spec.metadataNotes
index-search.Statefulset.yamlhas two containers,zoekt-webserverandzoekit-indexserver. They both sound equally important to me, so it is excluded from this PR.Test plan
tailing logs of frontend pod should no longer complain about specifying a container