-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix securityContext values name #48
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
079d07c
to
754e93c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change, so it requires bumping the minor version on the chart version.
Now that we've started combining multiple changes into a single release, and now have a breaking change, I think we should start producing a changelog. Before, it wasn't very important because one commit == one release.
754e93c
to
54a8e10
Compare
54a8e10
to
01d51e1
Compare
Added a changelog to record breaking changes. Also, I added a note to this the |
Co-authored-by: Crystal Augustus <91073224+caugustus-sourcegraph@users.noreply.github.com>
We're currently using and
podSecurityContext
as container-levelsecurityContext
(the naming is misleading)securityContext
as pod-levelsecurityContext
(okay, but we should be more explicit)This PR
podSecurityContext
tocontainerSecurityContext
securityContext
topodSecurityContext
Test plan
The test plan is to
diff
the output of rendered manifest, no change is expected.Revert to
main
There should be no difference.
close sourcegraph/sourcegraph#31888