Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing imagePullPolicy #49

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Conversation

mucles
Copy link
Contributor

@mucles mucles commented Feb 26, 2022

current a lot of images are missing imagePullPolicy. Search through all the yaml files that had images: and add the missing imagePullPolicy:

Test plan

Inspect the rendered template

helm template .

close sourcegraph/sourcegraph#31887

Copy link
Member

@michaellzc michaellzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@michaellzc michaellzc changed the title Helm: add missing imagePullPolicy Add missing imagePullPolicy Feb 26, 2022
@mucles mucles merged commit 9116a74 into main Feb 28, 2022
@mucles mucles deleted the manny/add-missing-image-pull-policy branch February 28, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm: add missing imagePullPolicy
3 participants