Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added copy code feature for mdx code blocks #330

Merged
merged 4 commits into from
May 23, 2024

Conversation

zahidalidev
Copy link
Collaborator

@zahidalidev zahidalidev commented May 16, 2024

  • Added a copy button for code blocks that allows users to easily copy code snippets from MDX code blocks with a single click.
  • Fixed table overflow issue

Pull Request approval

Although pull request approval is not enforced for this repository in order to reduce friction, merging without a review will generate a ticket for the docs team to review your changes. So if possible, have your pull request approved before merging.

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sourcegraph-docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 8:29pm

@MaedahBatool
Copy link
Collaborator

@zahidalidev I have reviewed the PR. The table issue seems to be fixed, but the copy code icons seem to be off in alignment in some places, especially with lengthy lines of code. The screenshot shows the overlap.

CleanShot 2024-05-21 at 12 18 35@2x

@MaedahBatool MaedahBatool self-requested a review May 21, 2024 19:23
@MaedahBatool MaedahBatool added documentation Improvements or additions to documentation enhancement New feature or request labels May 21, 2024
@zahidalidev
Copy link
Collaborator Author

@MaedahBatool I've pushed the changes and fixed the feedback points.

Copy link
Collaborator

@MaedahBatool MaedahBatool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaedahBatool MaedahBatool marked this pull request as ready for review May 23, 2024 18:07
@MaedahBatool MaedahBatool merged commit 7540a62 into sourcegraph:main May 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants