site: keep expired cache when background refresh failed #100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been pretty picky about freshness of the cached content (5m) and would aggressively delete the cache even if the background refresh failed.
It has the big assumption that the content host (GitHub.com) would never go down, and creates deep coupling of our docs site liveness directly with the liveness of the GitHub.com.
This PR removes that in the spirit of favoring stableness over freshness. It is better to have content got stale, than having the entire site down. Especially in the former case, the content would not be possible to be refreshed if the content host is also down in the first place.