Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SG-40884]: Turned off unicorn/prevent-abbreviations rule #260

Merged
merged 1 commit into from
Aug 26, 2022
Merged

[SG-40884]: Turned off unicorn/prevent-abbreviations rule #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
52 changes: 1 addition & 51 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,59 +277,10 @@ module.exports = {
// which is extremely common and necessary to maintain type safety.
'a',
'b',
// caught by prevent-abbreviations below, avoid double-flagging
'e',
'i',
'ch',
Comment on lines -280 to -283
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed these since there would be no longer double-flagging resulting from prevent-abbreviations rule

],
},
],
'unicorn/prevent-abbreviations': [
'error',
{
checkShorthandImports: false,
replacements: {
e: {
event: true,
error: true,
end: true, // as in e2e
},
i: { index: true },
idx: { index: true },
ch: { character: true },
j2d: { goToDefinition: true },
pos: { position: true },
opt: { options: true, option: true },
cmd: { command: true },
cmds: { commands: true },
loc: { location: true },
ext: { extension: true },
expr: { expression: true },
sub: { subscription: true },
subs: { subscriptions: true },
rect: { rectangle: true },
obs: { observable: true, observer: true },
resp: { response: true },
// When saving a document in a variable, we usually don't mean the the global document,
// but an extension API text document. Avoid shadowing suffixes.
doc: { document: false, textDocument: true },
// Never needed in our codebase, better to have an autofix for directory
dir: { direction: false },
// The meaning of rev vs ref is a common source of confusion.
// Spelling it out makes it clear.
rev: { revision: true },
// Allow since it's a React term
props: false,
func: false,
ref: false,
},
allowList: {
args: true, // arguments is special
fs: true, // NodeJS standard library
},
},
],

'unicorn/prevent-abbreviations': 'off',
'unused-imports/no-unused-imports': 'error',
'unused-imports/no-unused-vars': 'off',
// New rules added to unicorn
Expand Down Expand Up @@ -523,7 +474,6 @@ module.exports = {
rules: {
'no-var': 'off',
'@typescript-eslint/explicit-member-accessibility': 'off',
'unicorn/prevent-abbreviations': 'off',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed here, since it's not turned off globally.

'id-length': 'off',
'import/no-default-export': 'off',
},
Expand Down