Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support configuration #3

Merged
merged 1 commit into from
Apr 24, 2019
Merged

feat: support configuration #3

merged 1 commit into from
Apr 24, 2019

Conversation

felixfbecker
Copy link
Contributor

Stubs out sourcegraph.configuration.
Config can be set through the API's update() method.

@codecov-io
Copy link

Codecov Report

Merging #3 into master will increase coverage by 9.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   61.53%   70.58%   +9.04%     
==========================================
  Files           1        1              
  Lines          26       34       +8     
==========================================
+ Hits           16       24       +8     
  Misses         10       10
Impacted Files Coverage Δ
src/index.ts 70.58% <100%> (+9.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24d3c99...45bf0a6. Read the comment docs.

assert.deepStrictEqual(listener.args[1][0], undefined)
})
})
// describe('languages', () => {
Copy link

@vanesa vanesa Apr 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you merging this comment in too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment was there before, see above

@felixfbecker felixfbecker merged commit 8432004 into master Apr 24, 2019
@felixfbecker felixfbecker deleted the config branch April 24, 2019 20:35
@sourcegraph-bot
Copy link

🎉 This PR is included in version 0.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants