feat: mark safe GraphQL requests (#57)

src/client/clientCommands.ts

@@ -56,7 +56,12 @@ export function registerBuiltinClientCommands<S extends ConfigurationSubject, C
         controller.registries.commands.registerCommand({
             command: 'queryGraphQL',
             run: (query: string, variables: { [name: string]: any }): Promise<any> =>
-                from(context.queryGraphQL(query, variables)).toPromise(),
+                // 🚨 SECURITY: The request might contain private info (such as
+                // repository names), so the `mightContainPrivateInfo` parameter
+                // is set to `true`. It is up to the client (e.g. browser
+                // extension) to check that parameter and prevent the request
+                // from being sent to Sourcegraph.com.
+                from(context.queryGraphQL(query, variables, true)).toPromise(),
         })
     )
 

src/context.ts

@@ -31,11 +31,14 @@ export interface Context<S extends ConfigurationSubject, C extends Settings> {
      *
      * @param request The GraphQL request (query or mutation)
      * @param variables An object whose properties are GraphQL query name-value variable pairs
+     * @param mightContainPrivateInfo 🚨 SECURITY: Whether or not sending the GraphQL request to Sourcegraph.com
+     * could leak private information such as repository names.
      * @return Observable that emits the result or an error if the HTTP request failed
      */
     queryGraphQL(
         request: string,
-        variables?: { [name: string]: any }
+        variables?: { [name: string]: any },
+        mightContainPrivateInfo?: boolean
     ): Subscribable<QueryResult<Pick<GQL.IQuery, 'extensionRegistry'>>>
 
     /**

src/controller.ts

@@ -55,7 +55,8 @@ export class Controller<S extends ConfigurationSubject, C extends Settings> {
                     }
                     ${registryExtensionFragment}
                 `[graphQLContent],
-                { extensionID }
+                { extensionID },
+                false
             )
         )
             .pipe(
@@ -104,7 +105,8 @@ export class Controller<S extends ConfigurationSubject, C extends Settings> {
                 {
                     first: extensionIDs.length,
                     prioritizeExtensionIDs: extensionIDs,
-                }
+                },
+                false
             )
         ).pipe(
             map(({ data, errors }) => {

src/extensions/manager/ExtensionsList.tsx

@@ -271,7 +271,8 @@ export class ExtensionsList<S extends ConfigurationSubject, C extends Settings>
                         {
                             ...args,
                             prioritizeExtensionIDs: viewerExtensions.map(({ id }) => id),
-                        } as GQL.IExtensionsOnExtensionRegistryArguments
+                        } as GQL.IExtensionsOnExtensionRegistryArguments,
+                        false
                     )
                 ).pipe(
                     map(({ data, errors }) => {