This repository has been archived by the owner on Nov 6, 2018. It is now read-only.
feat: parameterize extension links #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: consumers now need to pass in a `link` prop when using the ExtensionStatusPopover.
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 15.91% 15.92% +0.01%
==========================================
Files 36 36
Lines 1125 1124 -1
Branches 256 287 +31
==========================================
Hits 179 179
+ Misses 946 945 -1
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 9.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: consumers now need to pass in a
linkprop when using the ExtensionStatusPopover.Previously,
Linkwouldn't work in the browser extension because there was noRouterto put i under.The browser extension will pass in
<a href=...and Sourcegraph will pass in<Link to=....