Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Windows support #113

Open
keegancsmith opened this issue Jan 25, 2017 · 8 comments
Open

Windows support #113

keegancsmith opened this issue Jan 25, 2017 · 8 comments

Comments

@keegancsmith
Copy link
Member

We have file path issues all over the place. We also have some in-progress work to sort this all out by @alexsaveliev. #86 #79

@ghost
Copy link

ghost commented Mar 30, 2017

+1 windows support needed

@suriyaa
Copy link

suriyaa commented Apr 6, 2017

👍

@levrik
Copy link

levrik commented Jul 25, 2018

I see several Windows PRs merged. Is this issue still relevant?

@keegancsmith
Copy link
Member Author

In theory it is working, we are running a windows based CI and the tests pass. Can you try the language server out on windows and tell me if it works? I don't have access to a windows machine.

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Aug 22, 2018

@keegancsmith This is great news. I gave this a try today from VS Code and found the below:

  • Hover, Go to definition, Format, Auto-completion works
  • References and Signature Help both fail with "import "/c:/GoCode/src/github.com/golang/example/hello": cannot import absolute path"
  • Workspace symbol search returns empty results, no error

@doxxx
Copy link

doxxx commented Oct 31, 2018

Repeating my comment here, I tested this using VSCode on Windows and everything worked except for Find References:

Find References works but suffers from the same problem as guru on Windows: searching for references of a symbol at the definition site of the symbol only finds references in the same package but searching for references from a usage site of the symbol outside of its package finds all references in all packages.

@ramya-rao-a
Copy link
Contributor

Thanks @doxxx! I can confirm the same.

@doxxx
Copy link

doxxx commented Jan 11, 2019

FYI, I have submitted a PR fixing the Find References bug on Windows in guru that I mentioned earlier: golang/tools#56

I tried searching the go-langserver code to see if the same fix was trivially applicable but I was not successful.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants