Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcs/gitcmd: Commits fails on pathspec with magic due to --follow parameter to git log #110

Closed
dmitshur opened this issue Jan 20, 2019 · 0 comments · Fixed by #111
Closed

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Jan 20, 2019

Using a pathspec that includes most magic (other than "top" and "literal") is not compatible with the --follow flag, whose documentation notes that it works only for a single file:

--follow
  Continue listing the history of a file beyond renames (works
  only for a single file).

This can be verified locally by running something like this in a git repository:

$ git log --follow HEAD -- ':(glob)*'
... (some output)
fatal: BUG:tree-diff.c:592: unsupported magic 8

$ git log HEAD -- ':(glob)*'
... (ok)

The --follow flag should only be added when vcs.CommitsOptions.Path specifies a single file rather than an unsupported magic.

More details are provided in the commit message of PR #111, which fixes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant