Refactor restore logic #1178
Merged
Refactor restore logic #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkondratek
force-pushed
the
mkondratek/chore/restore
branch
from
6d78a71
to
6e34e48
Compare
pkukielka
reviewed
Mar 26, 2024
| } else { | ||
| chatSession.restoreAgentSession(codyAgent, modelFromState) | ||
| } | ||
| val dummyConnectionId = codyAgent.server.chatNew() |
There was a problem hiding this comment.
Why it's dummyConnectionId ant not just connectionId?
There was a problem hiding this comment.
this is not the one we use eventually. pls take a look:
fun updateFromState(agent: CodyAgent, state: ChatState) {
val newConnectionId = restoreChatSession(agent, state)
connectionId.getAndSet(newConnectionId)
fetchLlms()
}
pkukielka
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor refactor needed for #1096.
It extracts the chat restore logic so it is doable to send the restore request without restoring the full session (with panels, etc).
Test plan