-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update extension name in plugin.xml #1184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Alex!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit scary to remove "Sourcegraph" from the name but I'm sure you've thought about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -1,6 +1,6 @@ | |||
<idea-plugin require-restart="true"> | |||
<id>com.sourcegraph.jetbrains</id> | |||
<name>Sourcegraph Cody + Code Search</name> | |||
<name>Cody: AI Coding Assistant with Autocomplete & Chat</name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Execution failed for task ':patchPluginXml'.
> org.jdom2.input.JDOMParseException: Error on line 3: The entity name must immediately follow the '&' in the entity reference.
Unfortunately &
will not work in xml file, it needs to be replaced with &
.
I will push fix if I can.
eaaea0e
to
483665b
Compare
Test plan
Metadata name change (for the marketplace) only. No specific tests.