Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extension name in plugin.xml #1184

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

iskyOS
Copy link
Contributor

@iskyOS iskyOS commented Mar 26, 2024

Test plan

Metadata name change (for the marketplace) only. No specific tests.

@iskyOS iskyOS linked an issue Mar 26, 2024 that may be closed by this pull request
Copy link
Contributor

@taylorsperry taylorsperry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Alex!

Copy link
Contributor

@vdavid vdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit scary to remove "Sourcegraph" from the name but I'm sure you've thought about it.

@pkukielka
Copy link
Contributor

A bit scary to remove "Sourcegraph" from the name but I'm sure you've thought about it.

Vendor will be still showing up, as it is defined in a separate filed:

image

image

Copy link
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,6 +1,6 @@
<idea-plugin require-restart="true">
<id>com.sourcegraph.jetbrains</id>
<name>Sourcegraph Cody + Code Search</name>
<name>Cody: AI Coding Assistant with Autocomplete & Chat</name>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Execution failed for task ':patchPluginXml'.
> org.jdom2.input.JDOMParseException: Error on line 3: The entity name must immediately follow the '&' in the entity reference.

Unfortunately & will not work in xml file, it needs to be replaced with &amp;.
I will push fix if I can.

@pkukielka pkukielka force-pushed the 1099-update-cody-extension-name-for-seo branch from eaaea0e to 483665b Compare April 2, 2024 16:39
@pkukielka pkukielka merged commit 9761f25 into main Apr 2, 2024
5 checks passed
@pkukielka pkukielka deleted the 1099-update-cody-extension-name-for-seo branch April 2, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Cody extension name for SEO
4 participants