Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repo dialog will accept repo names which don't contain a / #1198

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

dominiccooney
Copy link
Contributor

@dominiccooney dominiccooney commented Mar 27, 2024

This speculatively asks the remote to match the raw user input and the user input with the clone URL to repo name heuristic applied to it.

VSCode does not have this issue because repos are picked from a list retrieved from the remote, instead of input manually.

Fixes #1194

Test plan

Tested manually:

  • Breaking in validateRepoExists and check that we do fetch repo IDs for repo names without /, eg foo
  • Check remotes like ssh@github.com:sourcegraph/jetbrains still work
  • Check duplicate checks are still insensitive to exact input syntax, eg ssh@github.com:sourcegraph/jetbrains is detected as a duplicate of github:sourcegraph/jetbrains and https://github.com/sourcegraph/jetbrains.git, etc.

Copy link
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dominiccooney dominiccooney merged commit b33ee8d into main Mar 28, 2024
7 checks passed
@dominiccooney dominiccooney deleted the dpc/repo-validation-1194 branch March 28, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-repo validation code shouldn't require / characters
2 participants