Set default LLM to the last one used #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkukielka
commented
Apr 2, 2024
| @@ -53,10 +50,6 @@ class FixupService(val project: Project) : Disposable { | |||
| return true | |||
| } | |||
|
|
|||
| fun setCurrentModel(model: ChatModelsResponse.ChatModelProvider) { | |||
pkukielka
force-pushed
the
pkukielka/fix-llm-selection-for-commands
branch
from
af11c2f
to
97a298c
Compare
mkondratek
reviewed
Apr 2, 2024
| @@ -48,7 +48,7 @@ class EditCommandPrompt(val controller: FixupService, val editor: Editor, val di | |||
| LlmDropdown( | |||
| modelUsage = ModelUsage.EDIT, | |||
| project = controller.project, | |||
| onSetSelectedItem = controller::setCurrentModel, | |||
| onSetSelectedItem = {}, | |||
There was a problem hiding this comment.
this callback should persist the default for the inline edits, right?
There was a problem hiding this comment.
No, @danielmarquespt said the default between edits and chats should be the same.
We are already saving the default in LlmDropdown::setSelectedItem
pkukielka
force-pushed
the
pkukielka/fix-llm-selection-for-commands
branch
from
97a298c
to
b309f9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
User LLM selection is now saved and used for subsequest chats/edits.
TODO: new API for commands is needed to suport the same.
Test plan
Manual tests according to QA guide