Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change release script to determine next version based on tags #1275

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Change release script to determine next version based on tags #1275

merged 1 commit into from
Apr 3, 2024

Conversation

pkukielka
Copy link
Contributor

Changes

  1. Do not force push to release tags/branches (if you need to changes something after release use patch release)
  2. Do not use official GH releases to determine versions, as we no longer create those for the QA/nightly

Test plan

N/A

mkondratek
mkondratek approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@mkondratek mkondratek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pkukielka pkukielka merged commit d00854f into main Apr 3, 2024
4 checks passed
@pkukielka pkukielka deleted the pkukielka/change-release-script branch April 3, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkondratek mkondratek mkondratek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pkukielka @mkondratek