Update updatedAtTime only on sending a message instead of receiving it (fixes #1248)
#1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkondratek
changed the title
updatedAtTime only on sending a message instead of receiving it (fixes #1248)
mkondratek
commented
Apr 3, 2024
| @@ -41,7 +41,7 @@ import javax.swing.tree.DefaultTreeModel | |||
| import javax.swing.tree.TreePath | |||
| import javax.swing.tree.TreeSelectionModel | |||
|
|
|||
| class HistoryTree( | |||
| class ChatHistoryPanel( | |||
There was a problem hiding this comment.
NTOE: I piggyback this change.
This class is a panel actually, it extends SimpleToolWindowPanel.
pkukielka
reviewed
Apr 3, 2024
| val found = getOrCreateChat(internalId) | ||
| found.messages = chatMessages.map(::convertToMessageState).toMutableList() | ||
| if (chatMessages.lastOrNull()?.speaker == Speaker.HUMAN) { | ||
| if (shouldUpdateTime) { |
There was a problem hiding this comment.
I get all that changes, and they are correct, but I do not find that variable passing particularly clean.
I was thinking if we can simplify it somehow and I get one idea:
Shouldn't we update only, if found.messages count increased compared to what already is in the history? What would be one-line local check in this method.
mkondratek
commented
Apr 3, 2024
| @@ -253,6 +253,7 @@ private constructor( | |||
|
|
|||
| ChatMessage(speaker = parsed, message.text) | |||
| } | |||
| this.messages.addAll(chatMessages) | |||
There was a problem hiding this comment.
This is needed and reasonable too. Let's add all these message in advance. addMessageAtIndex will not even execute in receiveMessage as we check the condition: sessionMessage != incomingMessage.
mkondratek
force-pushed
the
mkondratek/chore/rename-to-chat-history-panel
branch
from
f06dd71
to
96b3eea
Compare
mkondratek
commented
Apr 3, 2024
| @@ -140,7 +140,9 @@ class HistoryTree( | |||
| } | |||
| } else { | |||
| val currentPeriodText = DurationGroupFormatter.format(chat.getUpdatedTimeAt()) | |||
| val currentPeriod = root.periods().find { it.periodText == currentPeriodText } ?: return | |||
mkondratek
force-pushed
the
mkondratek/chore/rename-to-chat-history-panel
branch
from
24fbc1a
to
65ac961
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1248.
Test plan
See the issue for specific steps.
Expected:
The restored chat remains as the last one in the list (it is not bumped to the top).