Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More work on Inline Edits dialog ui #1407

Merged
merged 2 commits into from
Apr 29, 2024
Merged

More work on Inline Edits dialog ui #1407

merged 2 commits into from
Apr 29, 2024

Conversation

steveyegge
Copy link
Contributor

Changes include:

  • refactored all the move/resize logic out of EditCommandPrompt into a helper class
  • got the move/resize logic working correcty and cleaned up
  • refactored some utilities into a helper class
  • did a more thorough job of listener cleanup on disposal

Test plan

This requires manual testing until we have UI/robot tests. It has a test in TESTING.md that covers this functionality (move/resize).

Changes include:
- refactored all the move/resize logic out of EditCommandPrompt into a helper class
- got the move/resize logic working correcty and cleaned up
- refactored some utilities into a helper class
- did a more thorough job of listener cleanup on disposal
@steveyegge steveyegge enabled auto-merge (squash) April 29, 2024 03:31
Copy link
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steveyegge steveyegge merged commit f71285b into main Apr 29, 2024
6 checks passed
@steveyegge steveyegge deleted the stevey/edit-ui-fixes branch April 29, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants