Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TESTING.md #694

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update TESTING.md #694

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2cb99bf
Update TESTING.md
aramaraju Feb 16, 2024
07ea2c8
Merge branch 'main' into guardrails-testcase-jb
cbart Apr 16, 2024
4a9f136
Specify success scenario attribution search test in detail
cbart Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions TESTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,3 +522,8 @@ Repeat the above starting from different themes.
#### Expected behaviour

Changing theme should lead to full repaint of the colours according to the current theme.

### Guardrails:

- [ ] Check if Guardrails check passes for any code longer than 10 lines generated in Cody Chat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thank for adding test scenario for Guardrails but it looks a bit incomplete to me.
It does not explain what Guardrails check is and how to check if it passed.
Ideally it should be in the form:

  1. Do to trigger some action
  2. Check if results looks like that:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to put in a detailed description of actions, and tangible expectation. Let me know if that works OK.

- [ ] Check if Guardrails check failes for any code longer than 10 lines that matches indexed OSS
cbart marked this conversation as resolved.
Show resolved Hide resolved