Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always omit params member from request when empty #67

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Always omit params member from request when empty #67

merged 3 commits into from
Feb 22, 2023

Commits on Feb 12, 2023

  1. Always omit params member from request when empty 

    With this commit, the JSON encoding of `Request` always omits the params
member when calling `Conn.Call`, `Conn.DispatchCall`, or `Conn.Notify`
with the `params` argument set to `nil`. This change also removes the
`OmitNilParams` call option that was added in commit 8012d49 (sourcegraph#62).

As of this commit, if users desire to send a JSON-RPC request with a
`params` value of `null`, then they may do so by explicitly setting the
`params` argument of `Conn.Call`/`Conn.DispatchCall`/`Conn.Notify` to
`json.RawMessage("null")`.
    @samherrmann
    samherrmann committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    7c2b0a0 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Uncomment code 

    The line of code changed in this commit was commented out by accident.
    @samherrmann
    samherrmann committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    f74a03b View commit details
    Browse the repository at this point in the history

  2. Add example test for null and omitted params

    @samherrmann
    samherrmann committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    75525c1 View commit details
    Browse the repository at this point in the history