Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentrycore: disable if sentry config is nil #58

Merged
merged 1 commit into from
May 18, 2023
Merged

Conversation

bobheadxi
Copy link
Member

Right now, removing Sentry config doesn't disable it because we return immediately here.

@bobheadxi bobheadxi requested review from jhchabran, burmudar and a team May 17, 2023 23:02
@codecov-commenter
Copy link

Codecov Report

Merging #58 (267052d) into main (49ac5ad) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   60.50%   60.41%   -0.10%     
==========================================
  Files          16       16              
  Lines         628      629       +1     
==========================================
  Hits          380      380              
- Misses        224      225       +1     
  Partials       24       24              
Impacted Files Coverage Δ
sinks_sentry.go 48.14% <0.00%> (-1.86%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bobheadxi bobheadxi merged commit 1102986 into main May 18, 2023
2 checks passed
@bobheadxi bobheadxi deleted the sentry-disable branch May 18, 2023 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants