Add a new format, JSON_GCP
#61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #61 +/- ##
=======================================
Coverage 61.62% 61.62%
=======================================
Files 16 16
Lines 641 641
=======================================
Hits 395 395
Misses 223 223
Partials 23 23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
burmudar
approved these changes
Jul 10, 2023
bobheadxi
approved these changes
Jul 10, 2023
output/output.go
Outdated
Comment on lines
25
to
28
| case string(FormatJSON), "logfmt": | ||
| // True 'logfmt' has significant limitations around certain field types: | ||
| // https://github.com/jsternberg/zap-logfmt#limitations so since it implies a | ||
| // desire for a somewhat structured format, we interpret it as OutputJSON. | ||
| "logfmt": | ||
| return FormatJSON | ||
| case string(FormatConsole), | ||
| case string(FormatConsole), "condensed": | ||
| // The previous 'condensed' format is optimized for local dev, so it serves the | ||
| // same purpose as OutputConsole | ||
| "condensed": |
There was a problem hiding this comment.
nit - keep the old formatting, or bring the docstring above the case
There was a problem hiding this comment.
Oh you're right, while it took me 2m to parse the original syntax with the line break and I like it much better that way, I missed that it messes how the comment reads now. Fixing this!
mucles
approved these changes
Jul 10, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deploying a service that sends out logs to cloud logging, the severity was not parsed and because logs of our services are all sent out of STDERR, they all defaulted to
severity: "ERROR", making it quite hard to read.This PRs adds a new
SRC_LOG_FORMAT=json_gcp, which outputs json logs in a structure that cloud logging understands.See the results of a little test in Cloud run: