Add query args as attributes #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
burmudar
reviewed
Aug 24, 2022
bobheadxi
reviewed
Aug 24, 2022
bobheadxi
approved these changes
Aug 24, 2022
jhchabran
force-pushed
the
args-attributes
branch
from
1481772
to
e371295
Compare
jhchabran
force-pushed
the
do-not-cache-tracer
branch
from
6a2850f
to
17a4c43
Compare
|
PR: XSAM#116 |
bobheadxi
force-pushed
the
args-attributes
branch
from
e371295
to
38f4a6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO review and send upstream PR
This PR adds support for decorating spans with the query arguments as attributes, in the form of
db.args.$n: value. ASkipoption is also provided to disable the mechanism if needed.