Pretty-print throws clause in method signatures
#160
Conversation
| @@ -17,7 +17,7 @@ private static String staticOverload(String value) { | |||
| return value + "1"; | |||
| } | |||
|
|
|||
| public static String app(int n, String m) { | |||
| public static String app(int n, String m) throws RuntimeException { | |||
There was a problem hiding this comment.
I'm surprised that epoxy doesn't use throws anywhere. Checked exceptions are IMO one of the biggest pains of working with Java. Can we add one test case where the exception has type parameters just to stress the code path that throws is Type and not symbols
There was a problem hiding this comment.
Turns out custom exceptions (that extend Exception/Throwable) cant have type parameters 🤔
There was a problem hiding this comment.
Where did you find examples with type parameters? Are they only in the JDK?
There was a problem hiding this comment.
There was a problem hiding this comment.
Not exactly "conclusive" or "proving" evidence by any means 😁
There was a problem hiding this comment.
Ive added an additional exception to the signature to make up for it. Gonna merge 👍
Strum355
force-pushed
the
nsc/method-throws-formatter
branch
from
ec7e190
to
6d6a27c
Compare
Add 'throws' field to
MethodSignaturein semanticdb for implementing pretty-printing, to be upstreamed to semanticdb spec.This is a fairly trivial change so it shouldnt be a big deal to upstream.
Closes #147