Add support for Gradle v7, fixes #164 #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strum355
reviewed
Apr 16, 2021
| |try { | ||
| | java.nio.file.Files.write( | ||
| | java.nio.file.Paths.get('$gradleVersionPath'), | ||
| | [gradle.gradleVersion], |
There was a problem hiding this comment.
Is this some scala feature Im not aware of?
There was a problem hiding this comment.
Which feature? This is a Groovy script, where you have literal syntax [a] for lists.
Strum355
reviewed
Apr 16, 2021
Comment on lines
+44
to
+55
| case Some(gradleVersion) | ||
| if gradleVersion.startsWith("6.7") && | ||
| toolchains.toolchains.nonEmpty => | ||
| index | ||
| .app | ||
| .error( | ||
| "lsif-java does not support Gradle 6.7 when used together with Java toolchains. " + | ||
| "To fix this problem, upgrade to Gradle version 6.8 or newer and try again." | ||
| ) | ||
| CommandResult(1, Nil) | ||
| case _ => | ||
| runCompileCommand(toolchains) |
There was a problem hiding this comment.
Will this still call runCompileCommand if if gradleVersion.startsWith("6.7") && toolchains.toolchains.nonEmpty evaluates to false?
There was a problem hiding this comment.
Yes, case _ => is a catchall
53 tasks
Strum355
approved these changes
Apr 16, 2021
Also adds a custom error message for users on Gradle v6.7 using the experimental toolchains feature. We can only support toolchains from version v6.8.
Strum355
modified the milestones:
Code Intelligence Iteration 9,
Code Intelligence Iteration 10
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a custom error message for users on Gradle v6.7 using the
experimental toolchains feature. We can only support toolchains from
version v6.8.