-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace emitting MarkedString[] with MarkupContent #179
Conversation
2b9d024
to
c8f8fb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor comments, otherwise looks good.
contents <- hoverResult.getContentsList.asScala | ||
} yield contents.getValue.trim | ||
sym -> hoverMessage.mkString("\n\n") | ||
val hover = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: for comprehensions become hard to read when you add a complicated chain of operations on top of it. I think this diff would read cleaner by keeping the original for comprehension and adding a separate statement instead
lsif-java/src/main/scala/com/sourcegraph/lsif_java/commands/SnapshotLsifCommand.scala
Outdated
Show resolved
Hide resolved
lsif-java/src/main/scala/com/sourcegraph/lsif_java/commands/SnapshotLsifCommand.scala
Show resolved
Hide resolved
lsif-semanticdb/src/main/java/com/sourcegraph/lsif_semanticdb/LsifSemanticdb.java
Outdated
Show resolved
Hide resolved
lsif-semanticdb/src/main/java/com/sourcegraph/lsif_semanticdb/LsifWriter.java
Outdated
Show resolved
Hide resolved
c8f8fb0
to
6fe81fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty to push a commit updating the for-comphrension. LGTM 馃憤
closes #162
Required some work in SnapshotLsifCommand.scala due to the new format. Also fixed a load of lint errors that Intellij kept throwing at me 馃檭