Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add folding ranges #82

Closed
wants to merge 1 commit into from
Closed

feat: add folding ranges #82

wants to merge 1 commit into from

Conversation

tjdevries
Copy link
Contributor

Test plan

  • ya

@olafurpg
Copy link
Member

As discussed offline, let's keep folding ranged outside of SCIP because folding ranges can be implemented with a syntactic tool like tree-sitter and doesn't benefit from semantic understanding of the code. One risk of using entirely different folding range implementations for different languages is that the folding behavior becomes inconsistent. I've personally never gotten much utility out of folding ranges in VS Code (partly because of how inconsistently it's implemented by different languages), compared to IntelliJ where I use folding ranges very frequently (although partly because the interaction between the cursor and folded ranges is significantly better in IntelliJ compared to VS Code). It's desirable to keep SCIP small and adding code folding ranges would be an unnecessary addition for now, although we can always reconsider this decision in the future if there's strong demand to include folding ranges in the protocol.

@olafurpg olafurpg closed this Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants