/
handler_test.go
250 lines (211 loc) · 8.93 KB
/
handler_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
package worker
import (
"context"
"fmt"
"io"
"os"
"strings"
"testing"
"github.com/google/go-cmp/cmp"
"github.com/sourcegraph/sourcegraph/cmd/frontend/backend"
"github.com/sourcegraph/sourcegraph/cmd/frontend/types"
"github.com/sourcegraph/sourcegraph/enterprise/cmd/precise-code-intel-worker/internal/metrics"
"github.com/sourcegraph/sourcegraph/enterprise/internal/codeintel/bloomfilter"
bundlemocks "github.com/sourcegraph/sourcegraph/enterprise/internal/codeintel/bundles/client/mocks"
bundletypes "github.com/sourcegraph/sourcegraph/enterprise/internal/codeintel/bundles/types"
gitservermocks "github.com/sourcegraph/sourcegraph/enterprise/internal/codeintel/gitserver/mocks"
"github.com/sourcegraph/sourcegraph/enterprise/internal/codeintel/store"
storemocks "github.com/sourcegraph/sourcegraph/enterprise/internal/codeintel/store/mocks"
"github.com/sourcegraph/sourcegraph/internal/api"
"github.com/sourcegraph/sourcegraph/internal/observation"
"github.com/sourcegraph/sourcegraph/internal/sqliteutil"
"github.com/sourcegraph/sourcegraph/internal/vcs"
)
func init() {
sqliteutil.SetLocalLibpath()
sqliteutil.MustRegisterSqlite3WithPcre()
}
func TestHandle(t *testing.T) {
setupRepoMocks(t)
upload := store.Upload{
ID: 42,
Root: "root/",
Commit: "deadbeef",
RepositoryID: 50,
Indexer: "lsif-go",
}
mockStore := storemocks.NewMockStore()
bundleManagerClient := bundlemocks.NewMockBundleManagerClient()
gitserverClient := gitservermocks.NewMockClient()
// Set default transaction behavior
mockStore.TransactFunc.SetDefaultReturn(mockStore, nil)
mockStore.DoneFunc.SetDefaultHook(func(err error) error { return err })
// Give correlation package a valid input dump
bundleManagerClient.GetUploadFunc.SetDefaultHook(copyTestDump)
// Allowlist all files in dump
gitserverClient.DirectoryChildrenFunc.SetDefaultReturn(map[string][]string{
"": {"foo.go", "bar.go"},
}, nil)
handler := &handler{
bundleManagerClient: bundleManagerClient,
gitserverClient: gitserverClient,
metrics: metrics.NewWorkerMetrics(&observation.TestContext),
}
requeued, err := handler.handle(context.Background(), mockStore, upload)
if err != nil {
t.Fatalf("unexpected error handlling upload: %s", err)
} else if requeued {
t.Errorf("unexpected requeue")
}
expectedPackages := []bundletypes.Package{
{DumpID: 42,
Scheme: "scheme B",
Name: "pkg B",
Version: "v1.2.3",
},
}
if len(mockStore.UpdatePackagesFunc.History()) != 1 {
t.Errorf("unexpected number of UpdatePackages calls. want=%d have=%d", 1, len(mockStore.UpdatePackagesFunc.History()))
} else if diff := cmp.Diff(expectedPackages, mockStore.UpdatePackagesFunc.History()[0].Arg1); diff != "" {
t.Errorf("unexpected UpdatePackagesFuncargs (-want +got):\n%s", diff)
}
filter, err := bloomfilter.CreateFilter([]string{"ident A"})
if err != nil {
t.Fatalf("unexpected error creating filter: %s", err)
}
expectedPackageReferences := []bundletypes.PackageReference{
{DumpID: 42,
Scheme: "scheme A",
Name: "pkg A",
Version: "v0.1.0",
Filter: filter,
},
}
if len(mockStore.UpdatePackageReferencesFunc.History()) != 1 {
t.Errorf("unexpected number of UpdatePackageReferences calls. want=%d have=%d", 1, len(mockStore.UpdatePackageReferencesFunc.History()))
} else if diff := cmp.Diff(expectedPackageReferences, mockStore.UpdatePackageReferencesFunc.History()[0].Arg1); diff != "" {
t.Errorf("unexpected UpdatePackageReferencesFunc args (-want +got):\n%s", diff)
}
if len(mockStore.DeleteOverlappingDumpsFunc.History()) != 1 {
t.Errorf("unexpected number of DeleteOverlappingDumps calls. want=%d have=%d", 1, len(mockStore.DeleteOverlappingDumpsFunc.History()))
} else if mockStore.DeleteOverlappingDumpsFunc.History()[0].Arg1 != 50 {
t.Errorf("unexpected value for repository id. want=%d have=%d", 50, mockStore.DeleteOverlappingDumpsFunc.History()[0].Arg1)
} else if mockStore.DeleteOverlappingDumpsFunc.History()[0].Arg2 != "deadbeef" {
t.Errorf("unexpected value for commit. want=%s have=%s", "deadbeef", mockStore.DeleteOverlappingDumpsFunc.History()[0].Arg2)
} else if mockStore.DeleteOverlappingDumpsFunc.History()[0].Arg3 != "root/" {
t.Errorf("unexpected value for root. want=%s have=%s", "root/", mockStore.DeleteOverlappingDumpsFunc.History()[0].Arg3)
} else if mockStore.DeleteOverlappingDumpsFunc.History()[0].Arg4 != "lsif-go" {
t.Errorf("unexpected value for indexer. want=%s have=%s", "lsif-go", mockStore.DeleteOverlappingDumpsFunc.History()[0].Arg4)
}
if len(mockStore.MarkRepositoryAsDirtyFunc.History()) != 1 {
t.Errorf("unexpected number of MarkRepositoryAsDirtyFunc calls. want=%d have=%d", 1, len(mockStore.MarkRepositoryAsDirtyFunc.History()))
} else if mockStore.MarkRepositoryAsDirtyFunc.History()[0].Arg1 != 50 {
t.Errorf("unexpected value for repository id. want=%d have=%d", 50, mockStore.MarkRepositoryAsDirtyFunc.History()[0].Arg1)
}
if len(bundleManagerClient.SendDBFunc.History()) != 1 {
t.Errorf("unexpected number of SendDB calls. want=%d have=%d", 1, len(bundleManagerClient.SendDBFunc.History()))
} else if bundleManagerClient.SendDBFunc.History()[0].Arg1 != 42 {
t.Errorf("unexpected SendDBFunc args. want=%d have=%d", 42, bundleManagerClient.SendDBFunc.History()[0].Arg1)
}
}
func TestHandleError(t *testing.T) {
setupRepoMocks(t)
upload := store.Upload{
ID: 42,
Root: "root/",
Commit: "deadbeef",
RepositoryID: 50,
Indexer: "lsif-go",
}
mockStore := storemocks.NewMockStore()
bundleManagerClient := bundlemocks.NewMockBundleManagerClient()
gitserverClient := gitservermocks.NewMockClient()
// Set default transaction behavior
mockStore.TransactFunc.SetDefaultReturn(mockStore, nil)
mockStore.DoneFunc.SetDefaultHook(func(err error) error { return err })
// Give correlation package a valid input dump
bundleManagerClient.GetUploadFunc.SetDefaultHook(copyTestDump)
// Set a different tip commit
mockStore.MarkRepositoryAsDirtyFunc.SetDefaultReturn(fmt.Errorf("uh-oh!"))
handler := &handler{
bundleManagerClient: bundleManagerClient,
gitserverClient: gitserverClient,
metrics: metrics.NewWorkerMetrics(&observation.TestContext),
}
requeued, err := handler.handle(context.Background(), mockStore, upload)
if err == nil {
t.Fatalf("unexpected nil error handling upload")
} else if !strings.Contains(err.Error(), "uh-oh!") {
t.Fatalf("unexpected error: %s", err)
} else if requeued {
t.Errorf("unexpected requeue")
}
if len(mockStore.DoneFunc.History()) != 1 {
t.Errorf("unexpected number of Done calls. want=%d have=%d", 1, len(mockStore.DoneFunc.History()))
}
if len(bundleManagerClient.DeleteUploadFunc.History()) != 1 {
t.Errorf("unexpected number of DeleteUpload calls. want=%d have=%d", 1, len(bundleManagerClient.DeleteUploadFunc.History()))
}
}
func TestHandleCloneInProgress(t *testing.T) {
t.Cleanup(func() {
backend.Mocks.Repos.Get = nil
backend.Mocks.Repos.ResolveRev = nil
})
backend.Mocks.Repos.Get = func(ctx context.Context, repoID api.RepoID) (*types.Repo, error) {
if repoID != api.RepoID(50) {
t.Errorf("unexpected repository name. want=%d have=%d", 50, repoID)
}
return &types.Repo{ID: repoID}, nil
}
backend.Mocks.Repos.ResolveRev = func(ctx context.Context, repo *types.Repo, rev string) (api.CommitID, error) {
return api.CommitID(""), &vcs.RepoNotExistError{Repo: repo.Name, CloneInProgress: true}
}
upload := store.Upload{
ID: 42,
Root: "root/",
Commit: "deadbeef",
RepositoryID: 50,
Indexer: "lsif-go",
}
mockStore := storemocks.NewMockStore()
bundleManagerClient := bundlemocks.NewMockBundleManagerClient()
gitserverClient := gitservermocks.NewMockClient()
handler := &handler{
bundleManagerClient: bundleManagerClient,
gitserverClient: gitserverClient,
metrics: metrics.NewWorkerMetrics(&observation.TestContext),
}
requeued, err := handler.handle(context.Background(), mockStore, upload)
if err != nil {
t.Fatalf("unexpected error handling upload: %s", err)
} else if !requeued {
t.Errorf("expected upload to be requeued")
}
if len(mockStore.RequeueFunc.History()) != 1 {
t.Errorf("unexpected number of RequeueFunc calls. want=%d have=%d", 1, len(mockStore.RequeueFunc.History()))
}
}
//
//
func copyTestDump(ctx context.Context, uploadID int) (io.ReadCloser, error) {
return os.Open("../../testdata/dump1.lsif")
}
func setupRepoMocks(t *testing.T) {
t.Cleanup(func() {
backend.Mocks.Repos.Get = nil
backend.Mocks.Repos.ResolveRev = nil
})
backend.Mocks.Repos.Get = func(ctx context.Context, repoID api.RepoID) (*types.Repo, error) {
if repoID != api.RepoID(50) {
t.Errorf("unexpected repository name. want=%d have=%d", 50, repoID)
}
return &types.Repo{ID: repoID}, nil
}
backend.Mocks.Repos.ResolveRev = func(ctx context.Context, repo *types.Repo, rev string) (api.CommitID, error) {
if rev != "deadbeef" {
t.Errorf("unexpected commit. want=%s have=%s", "deadbeef", rev)
}
return "", nil
}
}