Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 158: Code Intel UI Tracking Issue #10891

Closed
4 tasks done
shrouxm opened this issue May 20, 2020 · 4 comments
Closed
4 tasks done

RFC 158: Code Intel UI Tracking Issue #10891

shrouxm opened this issue May 20, 2020 · 4 comments
Assignees
Labels
design Design-oriented issues. It is not a design work request (use 'needs-design' instead) RFC-158 team/graph Graph Team (previously Code Intel/Language Tools/Language Platform) tracking
Milestone

Comments

@shrouxm
Copy link
Contributor

shrouxm commented May 20, 2020

Tracks work on RFC 158

@unassigned

Completed

@jjinnii

Completed

@oleggromov

Completed

@shrouxm
Copy link
Contributor Author

shrouxm commented May 22, 2020

General question for web re: implementing all of this:

As-is, this will require duplicate design + implementation work for the browser extension and on dot-com. Was it a conscious decision to style them differently than the equivalent UI elements on dot-com, and would it be possible to unify them and use the same components on dot-com and the extension?

@shrouxm shrouxm self-assigned this May 22, 2020
@shrouxm shrouxm added the team/graph Graph Team (previously Code Intel/Language Tools/Language Platform) label May 22, 2020
@shrouxm shrouxm added this to the 3.17 milestone May 22, 2020
@felixfbecker
Copy link
Contributor

As-is, this will require duplicate design + implementation work for the browser extension and on dot-com. Was it a conscious decision to style them differently than the equivalent UI elements on dot-com, and would it be possible to unify them and use the same components on dot-com and the extension?

We do use the same components, but give them different CSS classes, which was indeed a conscious decision. The browser extension UI should "fit into" the code host UI and not look alien. E.g. a button on GitHub should look like other buttons on GitHub, not like a button in our webapp.

@shrouxm
Copy link
Contributor Author

shrouxm commented May 22, 2020

OK, if they use the same components then my main concern is resolved.

It wasn't obvious to me whether they should or shouldn't be styled that way so I was curious if there was any prior discussion about it. I'll raise the issue again in a separate thread if I still have qualms after further thought.

@uwedeportivo
Copy link
Contributor

Dear all,

This is your release captain speaking. πŸš‚πŸš‚πŸš‚

Branch cut for the 3.17 release is scheduled for tomorrow.

Is this issue / PR going to make it in time? Please change the milestone accordingly.
When in doubt, reach out!

Thank you

@shrouxm shrouxm modified the milestones: 3.17, Backlog Jun 16, 2020
@aidaeology aidaeology added this to the Backlog milestone Jul 28, 2020
@quinnkeast quinnkeast changed the title RFC 158 Tracking Issue RFC 158: Code Intel UI Tracking Issue Aug 26, 2020
@macraig macraig added the design Design-oriented issues. It is not a design work request (use 'needs-design' instead) label May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design-oriented issues. It is not a design work request (use 'needs-design' instead) RFC-158 team/graph Graph Team (previously Code Intel/Language Tools/Language Platform) tracking
Projects
None yet
Development

No branches or pull requests

6 participants