Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary files in patch always show "no changes" #10998

Open
2 tasks
eseliger opened this issue May 26, 2020 · 0 comments
Open
2 tasks

Binary files in patch always show "no changes" #10998

eseliger opened this issue May 26, 2020 · 0 comments
Labels
batch-changes Issues related to Batch Changes bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. needs-design Design requests - add to 'design priorities' project, add a deadline, if possible..

Comments

@eseliger
Copy link
Member

In a binary patch, the file content is encoded in the diff either in literal or delta mode. We should add a function to go-diff probably, that allows to retrieve the file content (RFC1924 line-based encoded and zlib compressed, as far as I could reverse engineer).

Note: The first byte in a line is the line length.

Currently, we cannot get the file content, making it appear as an empty file, which has no way to determine it's binary, so "no changes" is shown.

image

Tasks

@eseliger eseliger added bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. campaigns estimate/3d batch-changes Issues related to Batch Changes labels May 26, 2020
@chrispine chrispine added this to the Backlog milestone Sep 16, 2020
@chrispine chrispine added planned/BatchersSprint12 batch-changes Issues related to Batch Changes and removed batch-changes Issues related to Batch Changes planned/BatchersSprint12 labels Apr 1, 2021
@chrispine chrispine added this to Backlog in Batchers - Backlog Apr 1, 2021
@chrispine chrispine removed this from the Backlog milestone Apr 27, 2021
@chrispine chrispine added the needs-design Design requests - add to 'design priorities' project, add a deadline, if possible.. label May 26, 2021
@chrispine chrispine added temp/batchers batch-changes Issues related to Batch Changes and removed batch-changes Issues related to Batch Changes temp/batchers labels Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch-changes Issues related to Batch Changes bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. needs-design Design requests - add to 'design priorities' project, add a deadline, if possible..
Projects
None yet
Development

No branches or pull requests

3 participants