Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make codeIntel.lsif true by default #13661

Closed
sqs opened this issue Sep 6, 2020 · 0 comments · Fixed by sourcegraph/code-intel-extensions#554
Closed

Make codeIntel.lsif true by default #13661

sqs opened this issue Sep 6, 2020 · 0 comments · Fixed by sourcegraph/code-intel-extensions#554
Labels
team/graph Graph Team (previously Code Intel/Language Tools/Language Platform)

Comments

@sqs
Copy link
Member

sqs commented Sep 6, 2020

After you upload LSIF data, you need to remember to set codeIntel.lsif to true in settings. This step seems unnecessary from the user's POV. Why would a user want to default to not using LSIF if it exists? I can see edge cases where they would want to disable LSIF (perhaps they're testing something, or someone uploaded bad LSIF data), but those seem like just that: (rare) edge cases.

If there's concern about perf impact, then at the very least we should add a notice to the repo settings LSIF pages telling the user to set codeIntel.lsif to true if it isn't already.

Related: Slack discussion from 2020-09-03

@sqs sqs added the team/graph Graph Team (previously Code Intel/Language Tools/Language Platform) label Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/graph Graph Team (previously Code Intel/Language Tools/Language Platform)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant